Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10377173: Do Keychain reauthorization at update time (Closed)

Created:
8 years, 7 months ago by Mark Mentovai
Modified:
8 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Do Keychain reauthorization at update time. In addition to the at-launch reauthorization, this adds an at-update reauthorization step. It only runs for users not on a system Keystone ticket, because the updater runs as root when on a system ticket, and root can't read individual user's Keychains. The at-update reauthorization is intended to handle the reauthorization for users who rarely restart Chrome and might miss out on the at-launch step during the window where Chrome is signed by the old certificate but has the new reauthorization code in place. The at-update reauthorization step can remain in place even after the certificate switch occurs by shipping an old reauthorization stub binary signed with the old certificate. BUG=108238 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137501

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -16 lines) Patch
M chrome/app/breakpad_mac.mm View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 1 3 chunks +48 lines, -9 lines 0 comments Download
M chrome/browser/mac/keychain_reauthorize.mm View 2 chunks +13 lines, -2 lines 0 comments Download
M chrome/chrome_installer.gypi View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/installer/mac/dmgdiffer.sh View 1 2 4 chunks +21 lines, -1 line 0 comments Download
A chrome/installer/mac/keychain_reauthorize_main.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M chrome/installer/mac/keystone_install.sh View 4 chunks +48 lines, -1 line 0 comments Download
M chrome/installer/mac/pkg-dmg View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
8 years, 7 months ago (2012-05-16 19:26:23 UTC) #1
TVL
lgtm https://chromiumcodereview.appspot.com/10377173/diff/1/chrome/browser/chrome_browser_main_mac.mm File chrome/browser/chrome_browser_main_mac.mm (right): https://chromiumcodereview.appspot.com/10377173/diff/1/chrome/browser/chrome_browser_main_mac.mm#newcode74 chrome/browser/chrome_browser_main_mac.mm:74: @"KeychainReauthorizeAtUpdateMay2012"; comment on when this key should be ...
8 years, 7 months ago (2012-05-16 20:05:10 UTC) #2
Mark Mentovai
8 years, 7 months ago (2012-05-16 20:24:52 UTC) #3
Addressed!

Powered by Google App Engine
This is Rietveld 408576698