Issue 10377171: Revert r1362: MSVS 2008: Fix to ensure that actions are re-run when the command changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10377171: Revert r1362: MSVS 2008: Fix to ensure that actions are re-run when the command changes (Closed)

Created:
8 years, 7 months ago by Mark Seaborn

Modified:
8 years, 7 months ago

Reviewers:
bradn, M-A Ruel

CC:
gyp-developer_googlegroups.com, Ryan Sleevi, jeanluc1

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Revert r1362: MSVS 2008: Fix to ensure that actions are re-run when the command changes This change caused a performance regression in the Windows incremental build on the Chromium bots, because the bots are deleting the new .gypcmd files from the source tree between runs, which triggers a lot of rebuilding. It's not practical to add the .gypcmd files to all the svn:ignore lists, so I'm reverting the change until we find a better solution. BUG=http://code.google.com/p/gyp/issues/detail?id=262 TEST=trybots Committed: https://code.google.com/p/gyp/source/detail?r=1383

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -127 lines)			Patch
M	pylib/gyp/generator/msvs.py	View	1 2	5 chunks	+6 lines, -23 lines	0 comments	Download
D	test/actions-args-change/gyptest-all.py	View		1 chunk	+0 lines, -48 lines	0 comments	Download
D	test/actions-args-change/src/arg-action.gyp	View		1 chunk	+0 lines, -35 lines	0 comments	Download
D	test/actions-args-change/src/arg-action.gypi	View		1 chunk	+0 lines, -9 lines	0 comments	Download
D	test/actions-args-change/src/dummy-fixed-input.txt	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	test/actions-args-change/src/write_file.py	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages

Issue 10377171: Revert r1362: MSVS 2008: Fix to ensure that actions are re-run when the command changes (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase again #

Messages