Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10377169: Added menuItem icon support, and little API for menu modification. (Closed)

Created:
8 years, 7 months ago by Dmitry Zvorygin
Modified:
8 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Added menuItem icon support, and little API for menu modification. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137687

Patch Set 1 #

Patch Set 2 : Added separator API. Simplified code. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M chrome/browser/resources/shared/js/cr/ui/menu.js View 1 2 chunks +42 lines, -0 lines 0 comments Download
M chrome/browser/resources/shared/js/cr/ui/menu_item.js View 2 chunks +15 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
Dmitry Zvorygin
8 years, 7 months ago (2012-05-16 13:58:10 UTC) #1
Dmitry Zvorygin
Added arv as reviewer.
8 years, 7 months ago (2012-05-16 14:23:14 UTC) #2
Dmitry Zvorygin
PTAL.
8 years, 7 months ago (2012-05-16 14:43:05 UTC) #3
dgozman
lgtm
8 years, 7 months ago (2012-05-16 14:45:19 UTC) #4
James Hawkins
http://codereview.chromium.org/10377169/diff/4001/chrome/browser/resources/shared/js/cr/ui/menu_item.js File chrome/browser/resources/shared/js/cr/ui/menu_item.js (right): http://codereview.chromium.org/10377169/diff/4001/chrome/browser/resources/shared/js/cr/ui/menu_item.js#newcode45 chrome/browser/resources/shared/js/cr/ui/menu_item.js:45: this.iconUrl = iconUrl; Why not: this.iconUrl = this.getAttribute('icon'); ?
8 years, 7 months ago (2012-05-16 17:12:18 UTC) #5
Dmitry Zvorygin
http://codereview.chromium.org/10377169/diff/4001/chrome/browser/resources/shared/js/cr/ui/menu_item.js File chrome/browser/resources/shared/js/cr/ui/menu_item.js (right): http://codereview.chromium.org/10377169/diff/4001/chrome/browser/resources/shared/js/cr/ui/menu_item.js#newcode45 chrome/browser/resources/shared/js/cr/ui/menu_item.js:45: this.iconUrl = iconUrl; On 2012/05/16 17:12:18, James Hawkins wrote: ...
8 years, 7 months ago (2012-05-17 12:11:14 UTC) #6
James Hawkins
lgtm
8 years, 7 months ago (2012-05-17 16:15:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/10377169/4001
8 years, 7 months ago (2012-05-17 16:32:49 UTC) #8
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 18:06:32 UTC) #9 
Change committed as 137687

Powered by Google App Engine
This is Rietveld 408576698