Issue 10377168: cros vpn config: Read UI data from the correct VPN dictionaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10377168: cros vpn config: Read UI data from the correct VPN dictionaries. (Closed)

Created:
8 years, 7 months ago by Mattias Nissler (ping if slow)

Modified:
8 years, 7 months ago

Reviewers:
Greg Spencer (Chromium), stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cros vpn config: Read UI data from the correct VPN dictionaries. In case of LT2P-IPsec VPN configurations, the code would read the Recommended flags for username and password from the wrong dictionary, resulting in the corresponding text boxes being disabled inadvertently. BUG=chromium:128097 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137473

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -16 lines)			Patch
	M	chrome/browser/chromeos/options/vpn_config_view.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/chromeos/options/vpn_config_view.cc	View		3 chunks	+37 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

Greg, Steven, can you look at this? The bug is marked Release-Block-Beta for 20, so ...

8 years, 7 months ago (2012-05-16 13:09:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/10377168/1

8 years, 7 months ago (2012-05-16 17:24:34 UTC) #4

Change committed as 137473

Expand Messages | Collapse Messages