Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 10377162: Merge 116672 - Web Inspector: search title is shown beside the search field (not under) in the vert… (Closed)

Created:
8 years, 7 months ago by pfeldman
Modified:
8 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 116672 - Web Inspector: search title is shown beside the search field (not under) in the vertical mode. https://bugs.webkit.org/show_bug.cgi?id=86120 Reviewed by Yury Semikhatsky. This change makes search title render as placeholder at all times. It also adjusts the size of the search field when navigation arrows appear. * inspector/front-end/SearchController.js: (WebInspector.SearchController): (WebInspector.SearchController.prototype.updateSearchLabel): (WebInspector.SearchController.prototype._updateSearchNavigationButtonState): (WebInspector.SearchController.prototype._createSearchNavigationButton): * inspector/front-end/inspector.css: (#toolbar-search-item): (.with-navigation-buttons #search): (.toolbar-search-navigation-label): (.with-navigation-buttons .toolbar-search-navigation-label): * inspector/front-end/inspector.html: TBR=pfeldman@chromium.org BUG=126550 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=117228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M Source/WebCore/inspector/front-end/SearchController.js View 4 chunks +7 lines, -15 lines 0 comments Download
M Source/WebCore/inspector/front-end/inspector.css View 3 chunks +8 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/front-end/inspector.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pfeldman
8 years, 7 months ago (2012-05-16 07:39:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698