Issue 10377161: aura-x11: Install the dispatcher as a message-pump observer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10377161: aura-x11: Install the dispatcher as a message-pump observer. (Closed)

Created:
8 years, 7 months ago by sadrul

Modified:
8 years, 7 months ago

Reviewers:
DaveMoore, sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura-x11: Install the dispatcher as a message-pump observer. DispatcherLinux may not always receive all events (e.g. when a menu is running a nested message-loop). So install it a message-pump observer, so that all X events go through the DL. Also, turn off the check for X-event consistency on release builds. BUG=128183 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137537

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -5 lines)			Patch
M	ui/aura/dispatcher_linux.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	ui/aura/dispatcher_linux.cc	View	3 chunks	+11 lines, -2 lines	0 comments	Download
M	ui/aura/root_window_host_linux.cc	View	2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

davemoore@ Please review. sky@ OWNERS http://codereview.chromium.org/10377161/diff/1/ui/aura/root_window_host_linux.cc File ui/aura/root_window_host_linux.cc (right): http://codereview.chromium.org/10377161/diff/1/ui/aura/root_window_host_linux.cc#newcode50 ui/aura/root_window_host_linux.cc:50: #if defined(USE_XI2_MT) && !defined(NDEBUG) ...

8 years, 7 months ago (2012-05-16 17:07:00 UTC) #1

Assuming this works ok with nested message loops, LGTM

Expand Messages | Collapse Messages