Issue 10377154: Fixing unneeded lifting of win_pch to an inner scope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10377154: Fixing unneeded lifting of win_pch to an inner scope. (Closed)

Created:
8 years, 7 months ago by bradn

Modified:
8 years, 7 months ago

Reviewers:
robertshield

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Fixing unneeded lifting of win_pch to an inner scope. This got left in r137083 by mistake, then further embelished in: http://codereview.chromium.org/10332173/ Only buildtype should need this treatment as win_pch is defined in terms of it. BUG=127875 TEST=builds on trybots. R=robertshield@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137233

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	build/common.gypi	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

8 years, 7 months ago (2012-05-15 20:24:07 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10377154/4003