Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10377122: Convert GdkPixbufFromSkBitmap and GdkPixbufToSkBitmap (Closed)

Created:
8 years, 7 months ago by pkotwicz
Modified:
8 years, 7 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, yoshiki+watch_chromium.org, jam, dcheng, joi+watch-content_chromium.org, Aaron Boodman, Satish, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Convert GdkPixbufFromSkBitmap(const SkBitmap*) to GdkPixbufFromSkBitmap(const SkBitmap&) Convert GdkPixbufToSkBitmap to GdkPixbufToImageSkia BUG=124566 TEST=Compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -51 lines) Patch
M chrome/browser/speech/speech_recognition_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_service_gtk.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/avatar_menu_item_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/content_setting_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/custom_button.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
chrome/browser/ui/gtk/menu_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/status_icons/status_icon_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/task_manager_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_source_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gtk_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gtk_util.cc View 2 chunks +7 lines, -7 lines 0 comments Download
ui/gfx/image/image.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/image/image_unittest_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webcursor_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
pkotwicz
8 years, 7 months ago (2012-05-14 00:24:35 UTC) #1
Elliot Glaysher
lgtm
8 years, 7 months ago (2012-05-14 16:31:53 UTC) #2
sky
LGTM
8 years, 7 months ago (2012-05-14 16:38:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10377122/1
8 years, 7 months ago (2012-05-14 18:06:51 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-14 18:07:19 UTC) #5 
Presubmit check for 10377122-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    webkit

Presubmit checks took 3.5s to calculate.

Powered by Google App Engine
This is Rietveld 408576698