Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 10377118: Send the correct referrer and policy when saving a file via PPAPI (Closed)

Created:
8 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Send the correct referrer and policy when saving a file via PPAPI BUG=124750 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137249

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M content/browser/web_contents/web_contents_impl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 5 chunks +7 lines, -5 lines 2 comments Download
M content/common/view_messages.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
jochen (gone - plz use gerrit)
Randy, Gene, please review Avi: owner stuff
8 years, 7 months ago (2012-05-12 00:15:34 UTC) #1
Randy Smith (Not in Mondays)
Swapping in Ben for me as it's save package related.
8 years, 7 months ago (2012-05-12 00:21:23 UTC) #2
jochen (gone - plz use gerrit)
btw, any suggestion how to test this would be welcome :)
8 years, 7 months ago (2012-05-12 00:21:58 UTC) #3
Avi (use Gerrit)
owner rubberstamp lgtm; get approval from someone who's qualified.
8 years, 7 months ago (2012-05-12 06:17:10 UTC) #4
benjhayden
Looks like this CL is currently just a small bit of plumbing, doesn't do what ...
8 years, 7 months ago (2012-05-14 13:56:20 UTC) #5
jochen (gone - plz use gerrit)
http://codereview.chromium.org/10377118/diff/1/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): http://codereview.chromium.org/10377118/diff/1/content/browser/web_contents/web_contents_impl.cc#newcode2722 content/browser/web_contents/web_contents_impl.cc:2722: // TODO(jochen): Pass in the referrer policy as well. ...
8 years, 7 months ago (2012-05-14 14:11:22 UTC) #6
benjhayden
LGTM http://codereview.chromium.org/10232010/ You don't need to update all of DUP's clients, just the ones that ...
8 years, 7 months ago (2012-05-14 14:30:17 UTC) #7
gene
lgtm
8 years, 7 months ago (2012-05-15 19:34:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10377118/1
8 years, 7 months ago (2012-05-15 19:35:00 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-15 21:23:48 UTC) #10
Change committed as 137249

Powered by Google App Engine
This is Rietveld 408576698