Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 10377101: Merge 116333 - IndexedDB: LevelDB coding for bools is broken (Closed)

Created:
8 years, 4 months ago by jsbell
Modified:
8 years, 4 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 116333 - IndexedDB: LevelDB coding for bools is broken https://bugs.webkit.org/show_bug.cgi?id=85810 Reviewed by Tony Chang. Source/WebCore: Code was appending to a pre-sized Vector, rather than using an index setter. This caused uninitialized data to be written out. Issue was detected on the Chromium side in http://crbug.com/126388 Tests: webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*codeBool' * Modules/indexeddb/IDBLevelDBCoding.cpp: (WebCore::IDBLevelDBCoding::encodeBool): Source/WebKit/chromium: Added tests for encodeBool/decodeBool. * tests/IDBLevelDBCodingTest.cpp: (IDBLevelDBCoding::TEST): (IDBLevelDBCoding): TBR=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=116706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jsbell
8 years, 4 months ago (2012-05-11 00:01:46 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698