Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: net/dns/dns_config_service_posix.h

Issue 10377092: [net/dns] Isolate DnsConfigWatcher from DnsConfigService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments. Braces. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/dns_config_service_posix.h
diff --git a/net/dns/dns_config_service_posix.h b/net/dns/dns_config_service_posix.h
index f28609bb0c7eb745c612c47acfb5d0e0731dde2a..30588efc194a300b3440fb445e443d107051e6a5 100644
--- a/net/dns/dns_config_service_posix.h
+++ b/net/dns/dns_config_service_posix.h
@@ -17,27 +17,17 @@
namespace net {
-class FilePathWatcherWrapper;
-
// Use DnsConfigService::CreateSystemService to use it outside of tests.
namespace internal {
-class NET_EXPORT_PRIVATE DnsConfigServicePosix
- : NON_EXPORTED_BASE(public DnsConfigService) {
+class NET_EXPORT_PRIVATE DnsConfigServicePosix : public DnsConfigService {
public:
DnsConfigServicePosix();
virtual ~DnsConfigServicePosix();
- virtual void Watch(const CallbackType& callback) OVERRIDE;
-
private:
- class ConfigWatcher;
-
- void OnConfigChanged(bool watch_succeeded);
- void OnHostsChanged(bool watch_succeeded);
-
- scoped_ptr<ConfigWatcher> config_watcher_;
- scoped_ptr<FilePathWatcherWrapper> hosts_watcher_;
+ // NetworkChangeNotifier::DNSObserver:
+ virtual void OnDNSChanged(unsigned detail) OVERRIDE;
scoped_refptr<SerialWorker> config_reader_;
scoped_refptr<SerialWorker> hosts_reader_;

Powered by Google App Engine
This is Rietveld 408576698