Don't mark JsonPrefStore as initialized in case of fatal failure.

Don't mark JsonPrefStore as initialized in case of fatal failure.

In code path OnPrefLoaded(success=false), JsonPrefStore is not marked as initialized, so ProfileImpl destructor doesn't try to access unregistered prefs.

BUG=122426
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136448

[Ivan Korotkov, 2012-05-10 12:23:31]

Hi Mattias, it seems that my previous fix doesn't cover all possible scenarios
for this crash, as we're still observing them:
http://crash.corp.google.com/reportview?product=Chrome&version=20.0.1126.0&si...
I think it makes sense to add the NULL-check and merge it back to M20.

[Mattias Nissler (ping if slow), 2012-05-10 13:45:08]

Talked to Bernhard about this. That stack trace is a known issue with Profiles
not initializing properly. Bernhard promised to update http://crbug.com/122426
with more information. Thanks!

[Mattias Nissler (ping if slow), 2012-05-10 13:54:39]

Passing on to Bernhard who knows more about this type of issue.

[Bernhard Bauer, 2012-05-10 14:05:50]

On 2012/05/10 13:54:39, Mattias Nissler wrote:
> Passing on to Bernhard who knows more about this type of issue.

These stack traces seem to have been caused by http://crbug.com/125009 (see
comment 25), which has since been fixed. I can't find any newer crash reports
than 1126, so I think this change is not necessary.

[Ivan Korotkov, 2012-05-10 15:36:05]

Updated as discussed with Bernhard, PTAL. Details in CL description.

[Mattias Nissler (ping if slow), 2012-05-10 15:44:04]

LGTM pending green tryjobs.

http://codereview.chromium.org/10377083/diff/7001/chrome/common/json_pref_sto...
File chrome/common/json_pref_store.cc (right):

http://codereview.chromium.org/10377083/diff/7001/chrome/common/json_pref_sto...
chrome/common/json_pref_store.cc:276: initialized_ = true;
Good catch.

[Bernhard Bauer, 2012-05-10 15:59:53]

LGTM with a small nit:

Could you update the description to something more imperative ("Don't mark...")?
Otherwise it could be confusing whether that describes the old version or the
new one.

[Ivan Korotkov, 2012-05-10 18:01:12]

Updated, submitting.

[commit-bot: I haz the power, 2012-05-10 18:02:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/10377083/7001

[commit-bot: I haz the power, 2012-05-10 18:38:35]

Try job failure for 10377083-7001 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Ivan Korotkov, 2012-05-10 21:32:27]

Something strange with LKGR on Mac

[commit-bot: I haz the power, 2012-05-10 21:32:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/10377083/7001

[commit-bot: I haz the power, 2012-05-10 23:36:41]

Change committed as 136448