Switched to chromium command line parsing code.

Switched to chromium command line parsing code.
Added logging.
Added switche for user data dir.
Added usage help.

Usage: cloud_print_service.exe [[[ -install -user-data-dir=DIRECTORY [ -quiet ]]] | -uninstall | -start | -stop ]
Manages cloud print service.

  -install        Installs cloud print as windows service.
  -user-data-dir  User data directory with "Service State" file.
  -quiet          Fails without questions if something wrong.
  -uninstall      Uninstalls windows service.
  -start          Starts windows service. May be combined with installation.
  -stop           Stops windows service.

BUG=125026
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136598

[gene, 2012-05-10 22:11:45]

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
File cloud_print/service/win/cloud_print_service.cc (right):

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
cloud_print/service/win/cloud_print_service.cc:63: std::cerr << "Usage: ";
cout?

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
cloud_print/service/win/cloud_print_service.cc:94: for (size_t i = 0; i <
arraysize(kSwitchHelp) / 2; ++i) {
change this to not use i*2+1

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
cloud_print/service/win/cloud_print_service.cc:120: if (!Uninstall())
We probably should not uninstall here, but rather stop service. I think, on
uninstall we'll want to delete 'Service State' file and delete all printers
associated with this connector. TODO is fine for now.

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
cloud_print/service/win/cloud_print_service.cc:123: if (user_data_dir.empty()) {
you can probably check this condition in the ParseCommandLine()

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
cloud_print/service/win/cloud_print_service.cc:192: hr = StopService();
I think we shall return here no matter what StopService() returned (to prevent
chaining of the commands).

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
cloud_print/service/win/cloud_print_service.cc:199: if (FAILED(hr))
Same as above here.

[Vitaly Buka (NO REVIEWS), 2012-05-10 22:49:12]

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
File cloud_print/service/win/cloud_print_service.cc (right):

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
cloud_print/service/win/cloud_print_service.cc:63: std::cerr << "Usage: ";
On 2012/05/10 22:11:45, gene wrote:
> cout?

Done.

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
cloud_print/service/win/cloud_print_service.cc:94: for (size_t i = 0; i <
arraysize(kSwitchHelp) / 2; ++i) {
On 2012/05/10 22:11:45, gene wrote:
> change this to not use i*2+1

Done.

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
cloud_print/service/win/cloud_print_service.cc:120: if (!Uninstall())
On 2012/05/10 22:11:45, gene wrote:
> We probably should not uninstall here, but rather stop service. I think, on
> uninstall we'll want to delete 'Service State' file and delete all printers
> associated with this connector. TODO is fine for now.

Done.

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
cloud_print/service/win/cloud_print_service.cc:123: if (user_data_dir.empty()) {
On 2012/05/10 22:11:45, gene wrote:
> you can probably check this condition in the ParseCommandLine()

Done.

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
cloud_print/service/win/cloud_print_service.cc:192: hr = StopService();
On 2012/05/10 22:11:45, gene wrote:
> I think we shall return here no matter what StopService() returned (to prevent
> chaining of the commands).

Done.

https://chromiumcodereview.appspot.com/10377080/diff/3004/cloud_print/service...
cloud_print/service/win/cloud_print_service.cc:199: if (FAILED(hr))
On 2012/05/10 22:11:45, gene wrote:
> Same as above here.

Done.

[gene, 2012-05-10 22:58:49]

https://chromiumcodereview.appspot.com/10377080/diff/10001/cloud_print/servic...
File cloud_print/service/win/cloud_print_service.cc (right):

https://chromiumcodereview.appspot.com/10377080/diff/10001/cloud_print/servic...
cloud_print/service/win/cloud_print_service.cc:96: std::cout <<
kSwitchHelp[i].name << "\n";
.name -> .description

https://chromiumcodereview.appspot.com/10377080/diff/10001/cloud_print/servic...
cloud_print/service/win/cloud_print_service.cc:203: return StartService();
 if (command_line.HasSwitch(kStartSwitch))   ???

[Vitaly Buka (NO REVIEWS), 2012-05-10 23:04:53]

https://chromiumcodereview.appspot.com/10377080/diff/10001/cloud_print/servic...
File cloud_print/service/win/cloud_print_service.cc (right):

https://chromiumcodereview.appspot.com/10377080/diff/10001/cloud_print/servic...
cloud_print/service/win/cloud_print_service.cc:96: std::cout <<
kSwitchHelp[i].name << "\n";
On 2012/05/10 22:58:49, gene wrote:
> .name -> .description

Done.

https://chromiumcodereview.appspot.com/10377080/diff/10001/cloud_print/servic...
cloud_print/service/win/cloud_print_service.cc:203: return StartService();
at line 200
On 2012/05/10 22:58:49, gene wrote:
>  if (command_line.HasSwitch(kStartSwitch))   ???

[gene, 2012-05-10 23:21:12]

lgtm

[commit-bot: I haz the power, 2012-05-10 23:32:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10377080/8005

[commit-bot: I haz the power, 2012-05-11 00:07:27]

Try job failure for 10377080-8005 (retry) on android for steps "Compile, build".
It's a second try, previously, steps "Compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...