Remove IsPendingDelete from PrerenderManager

Remove IsPendingDelete from PrerenderManager

We don't use IsPendingDelete or DidPrerenderFinishLoading, so remove them from our interface.

R=mmenke@chromium.org
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137832

[gavinp, 2012-05-08 23:09:00]

mmenke, WDYT?

[mmenke, 2012-05-09 14:32:35]

On 2012/05/08 23:09:00, gavinp wrote:
> mmenke, WDYT?

Wondering why we needed DidPrerenderFinishLoading, I looked at the CL that added
it - http://codereview.chromium.org/9387015.  It was upstreamed from Android,
which was using it at the time, but no code that depends on it has yet been
upstreamed.

I'm fine with the IsPendingDelete removal.  I think it's always only been using
in that DCHECK, and inlining it a visually smaller version of it seems fine.

[dominich, 2012-05-09 14:34:37]

Please leave the Android one.

Brevity by cellphone.
On May 9, 2012 7:32 AM, <mmenke@chromium.org> wrote:

> On 2012/05/08 23:09:00, gavinp wrote:
>
>> mmenke, WDYT?
>>
>
> Wondering why we needed DidPrerenderFinishLoading, I looked at the CL that
> added
> it -
http://codereview.chromium.**org/9387015<http://codereview.chromium.org/9387015>.
>  It was upstreamed from Android,
> which was using it at the time, but no code that depends on it has yet been
> upstreamed.
>
> I'm fine with the IsPendingDelete removal.  I think it's always only been
> using
> in that DCHECK, and inlining it a visually smaller version of it seems
> fine.
>
>
http://codereview.chromium.**org/10377058/<http://codereview.chromium.org/103...
>

[mmenke, 2012-05-09 14:35:59]

On 2012/05/09 14:32:35, Matt Menke wrote:
> On 2012/05/08 23:09:00, gavinp wrote:
> > mmenke, WDYT?
> 
> Wondering why we needed DidPrerenderFinishLoading, I looked at the CL that
added
> it - http://codereview.chromium.org/9387015.  It was upstreamed from Android,
> which was using it at the time, but no code that depends on it has yet been
> upstreamed.
> 
> I'm fine with the IsPendingDelete removal.  I think it's always only been
using
> in that DCHECK, and inlining it a visually smaller version of it seems fine.

Too...early....can't...type...English.

[mmenke, 2012-05-09 14:48:08]

http://codereview.chromium.org/10377058/diff/1/chrome/browser/prerender/prere...
File chrome/browser/prerender/prerender_manager.cc (right):

http://codereview.chromium.org/10377058/diff/1/chrome/browser/prerender/prere...
chrome/browser/prerender/prerender_manager.cc:524: DCHECK_EQ(0,
std::count(pending_delete_list_.begin(),
nit:  Might be nice to have a comment here, too.  I see this line, and have to
think.  Thinking is bad, no one does it well, or right.

[gavinp, 2012-05-15 10:14:46]

mmenke, dominich, WDYT?

[dominich, 2012-05-15 15:45:21]

Change the description to reflect only IsPendingDelete is being removed.

LGTM

[mmenke, 2012-05-15 15:47:54]

On 2012/05/15 15:45:21, dominich wrote:
> Change the description to reflect only IsPendingDelete is being removed.
> 
> LGTM

LGTM as well.

[commit-bot: I haz the power, 2012-05-18 01:28:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/10377058/9002

[commit-bot: I haz the power, 2012-05-18 02:29:11]

Try job failure for 10377058-9002 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-05-18 03:56:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/10377058/9002

[commit-bot: I haz the power, 2012-05-18 06:35:47]

Change committed as 137832