Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 10377053: Let GYP recognize the 'WDK_DIR' environment variable when generating ninja output on Windows. (Closed)

Created:
8 years, 7 months ago by alexeypa (please no reviews)
Modified:
8 years, 7 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
http://git.chromium.org/external/gyp.git@master
Visibility:
Public.

Description

Let GYP recognize the 'WDK_DIR' environment variable when generating ninja output on Windows. TEST=Build chrome.exe using the compiler from Windows SDK 7.1

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M pylib/gyp/msvs_emulation.py View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alexeypa (please no reviews)
Please take a look. This CL makes GYP to recognize the WDK_DIR variable so it ...
8 years, 7 months ago (2012-05-08 20:51:02 UTC) #1
alexeypa (please no reviews)
On 2012/05/08 20:51:02, alexeypa wrote: > Please take a look. This CL makes GYP to ...
8 years, 7 months ago (2012-05-08 20:51:37 UTC) #2
scottmg
lgtm https://chromiumcodereview.appspot.com/10377053/diff/1/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://chromiumcodereview.appspot.com/10377053/diff/1/pylib/gyp/msvs_emulation.py#newcode138 pylib/gyp/msvs_emulation.py:138: # the WDK_DIR environment variable. Return None if ...
8 years, 7 months ago (2012-05-08 20:54:26 UTC) #3
alexeypa (please no reviews)
FYI. https://chromiumcodereview.appspot.com/10377053/diff/1/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://chromiumcodereview.appspot.com/10377053/diff/1/pylib/gyp/msvs_emulation.py#newcode138 pylib/gyp/msvs_emulation.py:138: # the WDK_DIR environment variable. Return None if ...
8 years, 7 months ago (2012-05-08 20:58:25 UTC) #4
alexeypa (please no reviews)
8 years, 7 months ago (2012-05-08 22:52:56 UTC) #5
Commited as r1369.

Powered by Google App Engine
This is Rietveld 408576698