Issue 10377043: Fix function sorter from 11482 with correct fix. The sorter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10377043: Fix function sorter from 11482 with correct fix. The sorter (Closed)

Created:
8 years, 7 months ago by Erik Corry

Modified:
8 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix function sorter from 11482 with correct fix. The sorter was reverted from trunk 3.10.8.1, with this change we can repush it. Committed: https://code.google.com/p/v8/source/detail?r=11526

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -2 lines)			Patch
M	src/hydrogen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 7 months ago (2012-05-08 12:27:09 UTC) #2

LGTM (with a nit).

https://chromiumcodereview.appspot.com/10377043/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://chromiumcodereview.appspot.com/10377043/diff/1/src/objects-inl.h#newc...
src/objects-inl.h:3676: if (Code::FUNCTION != code()->kind()) return 0;
Could we flip the operands here?

Expand Messages | Collapse Messages