Do not send SetClientHasMemoryAllocationChanged after error.

Do not send SetClientHasMemoryAllocationChanged after error.

This is a fix for a crash hitting
DCHECK(last_state_.error == gpu::error::kNoError); in Send(), which
happens after unsuccessful initialization of hardware video decoder class
in GPU process.

BUG=
TEST=Manual run


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135694

[Ami GONE FROM CHROMIUM, 2012-05-06 23:03:11]

LGTM % nit (but you need an OWNERS LGTM before you can land this).

+kbr for OWNERS review (and moved mmocny to CC as FYI).

https://chromiumcodereview.appspot.com/10377031/diff/1/content/common/gpu/cli...
File content/common/gpu/client/command_buffer_proxy_impl.cc (right):

https://chromiumcodereview.appspot.com/10377031/diff/1/content/common/gpu/cli...
content/common/gpu/client/command_buffer_proxy_impl.cc:108: if
(last_state_.error == gpu::error::kNoError)
Multi-line if tests or bodies require braces around the body.  But if you
reverse the test and early-return (e.g. like
CommandBufferProxyImpl::SetSurfaceVisible and many other methods in this class)
then you don't need the braces or the extra indent.

[mmocny, 2012-05-07 13:15:12]

Thanks for catching this.

On 2012/05/06 23:03:11, Ami Fischman wrote:
> LGTM % nit (but you need an OWNERS LGTM before you can land this).
> 
> +kbr for OWNERS review (and moved mmocny to CC as FYI).
> 
>
https://chromiumcodereview.appspot.com/10377031/diff/1/content/common/gpu/cli...
> File content/common/gpu/client/command_buffer_proxy_impl.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10377031/diff/1/content/common/gpu/cli...
> content/common/gpu/client/command_buffer_proxy_impl.cc:108: if
> (last_state_.error == gpu::error::kNoError)
> Multi-line if tests or bodies require braces around the body.  But if you
> reverse the test and early-return (e.g. like
> CommandBufferProxyImpl::SetSurfaceVisible and many other methods in this
class)
> then you don't need the braces or the extra indent.

[Ken Russell (switch to Gerrit), 2012-05-07 17:09:49]

LGTM, but this test looks like a one-off and consequently fragile.

[commit-bot: I haz the power, 2012-05-07 17:36:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/posciak@chromium.org/10377031/5001

[commit-bot: I haz the power, 2012-05-07 19:15:47]

Change committed as 135694