Using arg parsing lib for dart2js.

lib/compiler/implementation/dart2js.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('dart2js');
 
 #import('dart:io');
 #import('dart:uri');
 #import('dart:utf');
 
+#import('../../args/args.dart');
 #import('../compiler.dart', prefix: 'api');
 #import('colors.dart', prefix: 'colors');
 #import('source_file.dart');
 #import('filenames.dart');
 #import('util/uri_extras.dart');
 
 final String LIBRARY_ROOT = '../../../..';
 
 void compile(List<String> argv) {
+  // Set up and parse the command line arguments.

[ahe, 2012/05/07 12:49:06]

Could you move the parser construction into a separate method?

[Bob Nystrom, 2012/05/07 18:22:05]

Done.

+  ArgParser parser = new ArgParser(usage: 'dart2js [options...] <entrypoint>');

[kasperl, 2012/05/07 11:49:35]

<entrypoint> -> <input>?

[ahe, 2012/05/07 12:49:06]

How about <dart file> or <file>?

[Bob Nystrom, 2012/05/07 18:22:05]

<input entrypoint dart file>? ;)

Changed to <dart file>

+  parser.addFlag('throw-on-error',
+      help: 'Throw an exception if a fatal error occurs');
+  parser.addFlag('suppress-warnings',
+      help: 'Display static warnings');
+  parser.addFlag('verbose', abbr: 'v',

[kasperl, 2012/05/07 11:49:35]

I'd prefer it if abbr wasn't abbreviated (feedback on lib/args).

[Bob Nystrom, 2012/05/07 18:22:05]

I'm not crazy about it either. I think I'll change it to "short" in a later
patch.

+      help: 'Display verbose output');
+  parser.addFlag('allow-mock-compilation');
+  parser.addFlag('colors', defaultsTo: true,
+      help: 'Use color when displaying output');
+  parser.addOption('library-root',
+      help: 'Path to core lib directory');
+  parser.addOption('out', abbr: 'o',
+      help: 'Output JavaScript file to create',
+    defaultsTo: 'out.js');

[kasperl, 2012/05/07 11:49:35]

Indentation.

[Bob Nystrom, 2012/05/07 18:22:05]

Done.

+
+  ArgResults results = parser.process(argv);
+
+  colors.enabled = results['colors'];
+  bool throwOnError = results['throw-on-error'];
+  bool showWarnings = !results['suppress-warnings'];
+  bool verbose = results['verbose'];
+
   Uri cwd = getCurrentDirectory();
-  bool throwOnError = false;
-  bool showWarnings = true;
-  bool verbose = false;
   Uri libraryRoot = cwd;
-  Uri out = cwd.resolve('out.js');
+  if (results['library-root'] != null) {
+    String path = nativeToUriPath(results['library-root']);
+    if (!path.endsWith("/")) path = "$path/";
+    libraryRoot = cwd.resolve(path);
+  }
+
+  Uri out = cwd.resolve(results['out']);
+
   List<String> options = new List<String>();
+  if (results['allow-mock-compilation']) {
+    options.add('--allow-mock-compilation');
+  }
 
-  List<String> arguments = <String>[];
-  for (String argument in argv) {
-    if ('--throw-on-error' == argument) {
-      throwOnError = true;
-    } else if ('--suppress-warnings' == argument) {
-      showWarnings = false;
-    } else if ('--verbose' == argument) {
-      verbose = true;
-    } else if (argument.startsWith('--library-root=')) {
-      String path =
-          nativeToUriPath(argument.substring(argument.indexOf('=') + 1));
-      if (!path.endsWith("/")) path = "$path/";
-      libraryRoot = cwd.resolve(path);
-    } else if (argument.startsWith('--out=')) {
-      String path =
-          nativeToUriPath(argument.substring(argument.indexOf('=') + 1));
-      out = cwd.resolve(path);
-    } else if ('--allow-mock-compilation' == argument) {
-      options.add(argument);
-    } else if ('--no-colors' == argument) {
-      colors.enabled = false;
-    } else if (argument.startsWith('-')) {
-      fail('Unknown option $argument.');
-    } else {
-      arguments.add(nativeToUriPath(argument));
-    }
-  }
+  List<String> arguments = results.rest.map(nativeToUriPath);
+
   if (arguments.isEmpty()) {
     fail('No file to compile.');
   }
+
   if (arguments.length > 1) {
     var extra = arguments.getRange(1, arguments.length - 1);
     fail('Extra arguments: $extra.');
   }
 
   Map<String, SourceFile> sourceFiles = <SourceFile>{};
   int dartBytesRead = 0;
 
   Future<String> provider(Uri uri) {
     if (uri.scheme != 'file') {
@@ skipping 87 matching lines @@
     } catch (var ignored) {
       print('Internal error: error while printing exception');
     }
     try {
       print(trace);
     } finally {
       exit(253); // 253 is recognized as a crash by our test scripts.
     }
   }
 }