Use a reserved stack local variable to store the Code object so that it can be looked up easily whe…

vm/parser.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_PARSER_H_
 #define VM_PARSER_H_
 
 #include "include/dart_api.h"
 
 #include "vm/ast.h"
@@ skipping 12 matching lines @@
 struct ClassDesc;
 struct MemberDesc;
 struct ParamList;
 struct QualIdent;
 struct CatchParamDesc;
 struct FieldInitExpression;
 
 // The class ParsedFunction holds the result of parsing a function.
 class ParsedFunction : ValueObject {
  public:
+  static const int kFirstStackSlotIndex = -2;

[regis, 2012/05/14 17:33:10]

The name is not clear, since parameters also occupy stack slots. How about
kFirstLocalSlotIndex?

In fact, you could also introduce a kLastParamSlotIndex (=1) and use it along
kFirstLocalSlotIndex in the offset calculations.

[siva, 2012/05/15 23:52:39]

Changed name as discussed offline.

The naming for +1 will be done in another CL.

On 2012/05/14 17:33:10, regis wrote:

+
   explicit ParsedFunction(const Function& function)
       : function_(function),
         node_sequence_(NULL),
         instantiator_(NULL),
         default_parameter_values_(Array::Handle()),
         saved_context_var_(NULL),
         expression_temp_var_(NULL),
         first_parameter_index_(0),
         first_stack_local_index_(0),
         copied_parameter_count_(0),
@@ skipping 477 matching lines @@
 
   // Allocate temporary only once per function.
   LocalVariable* expression_temp_;
 
   DISALLOW_COPY_AND_ASSIGN(Parser);
 };
 
 }  // namespace dart
 
 #endif  // VM_PARSER_H_