Issue 10375055: Minor cleanups to variation_service.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10375055: Minor cleanups to variation_service.cc. (Closed)

Created:
8 years, 7 months ago by Alexei Svitkine (slow)

Modified:
8 years, 7 months ago

Reviewers:
Ilya Sherman, jwd

CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Minor cleanups to variation_service.cc. - DCHECK(false) -> NOTREACHED() - Extract date conversion to a helper function BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137739

Patch Set 1 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	chrome/browser/metrics/variations_service.cc	View		4 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

LGTM. (I don't think Jesse is a committer yet, so he can only informally review ...

8 years, 7 months ago (2012-05-08 21:16:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10375055/3

8 years, 7 months ago (2012-05-08 21:31:26 UTC) #3

commit-bot: I haz the power

Try job failure for 10375055-3 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=27134 Step "update" is always ...

8 years, 7 months ago (2012-05-08 21:46:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10375055/3

8 years, 7 months ago (2012-05-17 20:00:10 UTC) #5

Change committed as 137739

Expand Messages | Collapse Messages