Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: Source/WebCore/rendering/RenderInline.cpp

Issue 10375053: Merge 115458 - NULL-deref in RenderBox::clippedOverflowRectForRepaint (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/inline/crash-new-continuation-with-outline-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 1040 matching lines...) Expand 10 before | Expand all | Expand 10 after
1051 cb->computeRectForRepaint(repaintContainer, r); 1051 cb->computeRectForRepaint(repaintContainer, r);
1052 1052
1053 if (ow) { 1053 if (ow) {
1054 for (RenderObject* curr = firstChild(); curr; curr = curr->nextSibling() ) { 1054 for (RenderObject* curr = firstChild(); curr; curr = curr->nextSibling() ) {
1055 if (!curr->isText()) { 1055 if (!curr->isText()) {
1056 LayoutRect childRect = curr->rectWithOutlineForRepaint(repaintCo ntainer, ow); 1056 LayoutRect childRect = curr->rectWithOutlineForRepaint(repaintCo ntainer, ow);
1057 r.unite(childRect); 1057 r.unite(childRect);
1058 } 1058 }
1059 } 1059 }
1060 1060
1061 if (continuation() && !continuation()->isInline()) { 1061 if (continuation() && !continuation()->isInline() && continuation()->par ent()) {
1062 LayoutRect contRect = continuation()->rectWithOutlineForRepaint(repa intContainer, ow); 1062 LayoutRect contRect = continuation()->rectWithOutlineForRepaint(repa intContainer, ow);
1063 r.unite(contRect); 1063 r.unite(contRect);
1064 } 1064 }
1065 } 1065 }
1066 1066
1067 return r; 1067 return r;
1068 } 1068 }
1069 1069
1070 LayoutRect RenderInline::rectWithOutlineForRepaint(RenderBoxModelObject* repaint Container, LayoutUnit outlineWidth) const 1070 LayoutRect RenderInline::rectWithOutlineForRepaint(RenderBoxModelObject* repaint Container, LayoutUnit outlineWidth) const
1071 { 1071 {
(...skipping 522 matching lines...) Expand 10 before | Expand all | Expand 10 after
1594 FloatPoint absPos = container->localToAbsolute(); 1594 FloatPoint absPos = container->localToAbsolute();
1595 region.bounds.setX(absPos.x() + region.bounds.x()); 1595 region.bounds.setX(absPos.x() + region.bounds.x());
1596 region.bounds.setY(absPos.y() + region.bounds.y()); 1596 region.bounds.setY(absPos.y() + region.bounds.y());
1597 1597
1598 regions.append(region); 1598 regions.append(region);
1599 } 1599 }
1600 } 1600 }
1601 #endif 1601 #endif
1602 1602
1603 } // namespace WebCore 1603 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/inline/crash-new-continuation-with-outline-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698