Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 10375049: Fix the incorrect include headers in 64-bit arch host for android x86 build (Closed)

Created:
8 years, 7 months ago by Shouqun Liu
Modified:
8 years, 7 months ago
Reviewers:
John Grabowski, Yaron
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix the incorrect include headers in 64-bit arch host for android x86 build This patch disable '/usr/include32' as the include dir for android x86 build in 64-bit host, otherwise, this include entry causes headers conflict with android NDK headers. BUG=126611 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/common.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Shouqun Liu
8 years, 7 months ago (2012-05-09 05:19:22 UTC) #1
Nico
Please pick at most 2 reviewers for files touching just one file. Removing myself.
8 years, 7 months ago (2012-05-09 05:20:47 UTC) #2
John Grabowski
Strong LGTM
8 years, 7 months ago (2012-05-09 15:16:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/10375049/1
8 years, 7 months ago (2012-05-10 01:12:52 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-10 03:22:32 UTC) #5
Change committed as 136238

Powered by Google App Engine
This is Rietveld 408576698