frog/tests/leg/ssa_phi_codegen_test.dart - Issue 10375048: Don't allow phi equivalences along back-edges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/tests/leg/ssa_phi_codegen_test.dart

Issue 10375048: Don't allow phi equivalences along back-edges. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Added test. Updated other tests. Simplified isPhiBefore. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: frog/tests/leg/ssa_phi_codegen_test.dart

diff --git a/frog/tests/leg/ssa_phi_codegen_test.dart b/frog/tests/leg/ssa_phi_codegen_test.dart

index 6b2b5d633f07ef75686957187247f443ebcb3760..84f36dab9eefe08c3726c2c2d5baaa2412919381 100644

--- a/frog/tests/leg/ssa_phi_codegen_test.dart

+++ b/frog/tests/leg/ssa_phi_codegen_test.dart

@@ -66,8 +66,10 @@ main() {

Expect.isTrue(regexp.hasMatch(generated));

generated = compile(TEST_TWO, 'main');

+ // TODO(ngeoffray): Add live range analysis to the codegen

+ // to make this test pass.

regexp = new RegExp("t = \\(?$anyIdentifier +");

- Expect.isTrue(regexp.hasMatch(generated));

+ Expect.isFalse(regexp.hasMatch(generated));

// TODO(ngeoffray): Add live range analysis to the codegen

// to make this test pass.