Don't allow phi equivalences along back-edges.

lib/compiler/implementation/ssa/codegen_helpers.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Instead of emitting each SSA instruction with a temporary variable
  * mark instructions that can be emitted at their use-site.
  * For example, in:
  *   t0 = 4;
  *   t1 = 3;
@@ skipping 422 matching lines @@
   // All binary operators (excluding assignment) are left associative.
   int get precedence() => left;
 }
 
 class PhiEquivalator {
   final Equivalence<HPhi> equivalence;
   final Map<HPhi, String> logicalOperations;
   PhiEquivalator(this.equivalence, this.logicalOperations);
 
   void analyzeGraph(HGraph graph) {
-    graph.blocks.forEach((HBasicBlock block) => analyzeBlock(block));
+    graph.blocks.forEach(analyzeBlock);
+  }
+
+  static bool isPhiBeforeUse(HPhi phi1) {
+    assert(phi1.usedBy.length == 1);
+    HPhi phi2 = phi1.usedBy[0];
+    // A phi can never be used in another phi in the same block.

[ngeoffray, 2012/05/08 09:13:01]

That you could assert here.

[Lasse Reichstein Nielsen, 2012/05/08 09:17:14]

I'll just inline it all in the test that already tested that.

+    return phi1.block.id < phi2.block.id;

[ngeoffray, 2012/05/08 09:13:01]

If that is true, maybe also assert that phi2 is a loop phi?

[Lasse Reichstein Nielsen, 2012/05/08 09:17:14]

Not sure it's necessary. If it's an invariant, it's probably already checked by
the validator, and if not, it should not be asserted.

   }
 
   void analyzeBlock(HBasicBlock block) {
     for (HPhi phi = block.phis.first; phi !== null; phi = phi.next) {
       if (!logicalOperations.containsKey(phi) &&
           phi.usedBy.length == 1 &&
-          phi.usedBy[0] is HPhi) {
+          phi.usedBy[0] is HPhi &&
+          isPhiBeforeUse(phi)) {
         equivalence.makeEquivalent(phi, phi.usedBy[0]);
       }
     }
   }
 }
 
 
 /**
  * Try to figure out which phis can be represented by the same temporary
  * variable, to avoid creating a new variable for each phi.
@@ skipping 31 matching lines @@
     // improving the performance of future lookups.
     T root = getRepresentative(parent);
     if (root !== parent) representative[element] = root;
     return root;
   }
 
   bool areEquivalent(T a, T b) {
     return getRepresentative(a) === getRepresentative(b);
   }
 }