Add libva to chromium third_party.

Add libva to chromium third_party.

BUG=126466
TEST=checklicenses passes with the new exception (pending getting upstream to conform)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135647

[Ami GONE FROM CHROMIUM, 2012-05-07 15:15:37]

phajdan.jr: please review
posciak: FYI

[Paweł Hajdan Jr., 2012-05-07 15:17:29]

https://chromiumcodereview.appspot.com/10375035/diff/1/tools/checklicenses/ch...
File tools/checklicenses/checklicenses.py (right):

https://chromiumcodereview.appspot.com/10375035/diff/1/tools/checklicenses/ch...
tools/checklicenses/checklicenses.py:268: 'third_party/libva/': [  #
http://crbug.com/126466
1. Please file an upstream bug and use the upstream link here.
2. Please list individual files, not the entire dir.

[Paweł Hajdan Jr., 2012-05-07 15:21:23]

Ah, and compared to https://chromiumcodereview.appspot.com/10380004/ this checks
in more files. I don't think e.g. debian.upstream is needed.

[Ami GONE FROM CHROMIUM, 2012-05-07 15:31:16]

On 2012/05/07 15:17:29, Paweł Hajdan Jr. wrote:
>
https://chromiumcodereview.appspot.com/10375035/diff/1/tools/checklicenses/ch...
> File tools/checklicenses/checklicenses.py (right):
> 
>
https://chromiumcodereview.appspot.com/10375035/diff/1/tools/checklicenses/ch...
> tools/checklicenses/checklicenses.py:268: 'third_party/libva/': [  #
> http://crbug.com/126466
> 1. Please file an upstream bug and use the upstream link here.

Upstream lists only contact addresses @intel, no bugtracker.  Sending them an
email.

> 2. Please list individual files, not the entire dir.

Done.

[Ami GONE FROM CHROMIUM, 2012-05-07 15:32:30]

On 2012/05/07 15:21:23, Paweł Hajdan Jr. wrote:
> Ah, and compared to https://chromiumcodereview.appspot.com/10380004/ this
checks
> in more files. I don't think e.g. debian.upstream is needed.

I chose to dump the entire remote repo into this CL to avoid having to pick &
choose.
ISTM doing things this way makes later updates much easier (unless we write
scripts to manage inclusion/exclusion).

[Paweł Hajdan Jr., 2012-05-07 15:37:42]

On 2012/05/07 15:31:16, Ami Fischman wrote:
> On 2012/05/07 15:17:29, Paweł Hajdan Jr. wrote:
> >
>
https://chromiumcodereview.appspot.com/10375035/diff/1/tools/checklicenses/ch...
> > File tools/checklicenses/checklicenses.py (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10375035/diff/1/tools/checklicenses/ch...
> > tools/checklicenses/checklicenses.py:268: 'third_party/libva/': [  #
> > http://crbug.com/126466
> > 1. Please file an upstream bug and use the upstream link here.
> 
> Upstream lists only contact addresses @intel, no bugtracker.  Sending them an
> email.

bugs.freedesktop.org lists "libva" product. Please file a bug there. Agreed that
the place is not very obvious.

> > 2. Please list individual files, not the entire dir.
> 
> Done.

On 2012/05/07 15:32:30, Ami Fischman wrote:
> On 2012/05/07 15:21:23, Paweł Hajdan Jr. wrote:
> > Ah, and compared to https://chromiumcodereview.appspot.com/10380004/ this
> checks
> > in more files. I don't think e.g. debian.upstream is needed.
> 
> I chose to dump the entire remote repo into this CL to avoid having to pick &
> choose.
> ISTM doing things this way makes later updates much easier (unless we write
> scripts to manage inclusion/exclusion).

Generally in Chromium codebase when the lib is only dlopened we only check the
headers. Seriously, checking the entire lib now seems like an overkill. When we
need all of it, then yes, checking in entire repo would be the right thing to
do.

[Ami GONE FROM CHROMIUM, 2012-05-07 15:48:39]

On 2012/05/07 15:37:42, Paweł Hajdan Jr. wrote:
> On 2012/05/07 15:31:16, Ami Fischman wrote:
> > On 2012/05/07 15:17:29, Paweł Hajdan Jr. wrote:
> > >
> >
>
https://chromiumcodereview.appspot.com/10375035/diff/1/tools/checklicenses/ch...
> > > File tools/checklicenses/checklicenses.py (right):
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/10375035/diff/1/tools/checklicenses/ch...
> > > tools/checklicenses/checklicenses.py:268: 'third_party/libva/': [  #
> > > http://crbug.com/126466
> > > 1. Please file an upstream bug and use the upstream link here.
> > 
> > Upstream lists only contact addresses @intel, no bugtracker.  Sending them
an
> > email.
> 
> http://bugs.freedesktop.org lists "libva" product. Please file a bug there.
Agreed that
> the place is not very obvious.

Done: https://bugs.freedesktop.org/show_bug.cgi?id=49588

> Generally in Chromium codebase when the lib is only dlopened we only check the
> headers. Seriously, checking the entire lib now seems like an overkill. When
we
> need all of it, then yes, checking in entire repo would be the right thing to
> do.

I don't know what you mean by "overkill", and your way results in more work for
the next drop, but I want to get the other stuff unblocked, so done ;)

[Paweł Hajdan Jr., 2012-05-07 15:49:26]

LGTM

Thanks!

https://chromiumcodereview.appspot.com/10375035/diff/7042/third_party/libva/v...
File third_party/libva/va/android/va_dummy.c (right):

https://chromiumcodereview.appspot.com/10375035/diff/7042/third_party/libva/v...
third_party/libva/va/android/va_dummy.c:1: va_android.cpp
Is this va_dummy.c file needed?

https://chromiumcodereview.appspot.com/10375035/diff/7042/tools/checklicenses...
File tools/checklicenses/checklicenses.py (right):

https://chromiumcodereview.appspot.com/10375035/diff/7042/tools/checklicenses...
tools/checklicenses/checklicenses.py:269: 'third_party/libva/va/va_x11.h': [
Make sure to only list files present in the CL (I think at least one .c file has
been removed).

[Ami GONE FROM CHROMIUM, 2012-05-07 15:52:58]

https://chromiumcodereview.appspot.com/10375035/diff/7042/third_party/libva/v...
File third_party/libva/va/android/va_dummy.c (right):

https://chromiumcodereview.appspot.com/10375035/diff/7042/third_party/libva/v...
third_party/libva/va/android/va_dummy.c:1: va_android.cpp
On 2012/05/07 15:49:26, Paweł Hajdan Jr. wrote:
> Is this va_dummy.c file needed?

Nope; gone.

https://chromiumcodereview.appspot.com/10375035/diff/7042/tools/checklicenses...
File tools/checklicenses/checklicenses.py (right):

https://chromiumcodereview.appspot.com/10375035/diff/7042/tools/checklicenses...
tools/checklicenses/checklicenses.py:269: 'third_party/libva/va/va_x11.h': [
On 2012/05/07 15:49:26, Paweł Hajdan Jr. wrote:
> Make sure to only list files present in the CL (I think at least one .c file
has
> been removed).

Done.