Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: src/arm/ic-arm.cc

Issue 10375033: Fix unsigned-Smi check in MappedArgumentsLookup (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | src/ia32/ic-ia32.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 756 matching lines...) Expand 10 before | Expand all | Expand 10 after
767 767
768 // Check that the receiver is a JSObject. Because of the map check 768 // Check that the receiver is a JSObject. Because of the map check
769 // later, we do not need to check for interceptors or whether it 769 // later, we do not need to check for interceptors or whether it
770 // requires access checks. 770 // requires access checks.
771 __ JumpIfSmi(object, slow_case); 771 __ JumpIfSmi(object, slow_case);
772 // Check that the object is some kind of JSObject. 772 // Check that the object is some kind of JSObject.
773 __ CompareObjectType(object, scratch1, scratch2, FIRST_JS_RECEIVER_TYPE); 773 __ CompareObjectType(object, scratch1, scratch2, FIRST_JS_RECEIVER_TYPE);
774 __ b(lt, slow_case); 774 __ b(lt, slow_case);
775 775
776 // Check that the key is a positive smi. 776 // Check that the key is a positive smi.
777 __ tst(key, Operand(0x8000001)); 777 __ tst(key, Operand(0x80000001));
778 __ b(ne, slow_case); 778 __ b(ne, slow_case);
779 779
780 // Load the elements into scratch1 and check its map. 780 // Load the elements into scratch1 and check its map.
781 Handle<Map> arguments_map(heap->non_strict_arguments_elements_map()); 781 Handle<Map> arguments_map(heap->non_strict_arguments_elements_map());
782 __ ldr(scratch1, FieldMemOperand(object, JSObject::kElementsOffset)); 782 __ ldr(scratch1, FieldMemOperand(object, JSObject::kElementsOffset));
783 __ CheckMap(scratch1, scratch2, arguments_map, slow_case, DONT_DO_SMI_CHECK); 783 __ CheckMap(scratch1, scratch2, arguments_map, slow_case, DONT_DO_SMI_CHECK);
784 784
785 // Check if element is in the range of mapped arguments. If not, jump 785 // Check if element is in the range of mapped arguments. If not, jump
786 // to the unmapped lookup with the parameter map in scratch1. 786 // to the unmapped lookup with the parameter map in scratch1.
787 __ ldr(scratch2, FieldMemOperand(scratch1, FixedArray::kLengthOffset)); 787 __ ldr(scratch2, FieldMemOperand(scratch1, FixedArray::kLengthOffset));
(...skipping 967 matching lines...) Expand 10 before | Expand all | Expand 10 after
1755 } else { 1755 } else {
1756 ASSERT(Assembler::GetCondition(branch_instr) == ne); 1756 ASSERT(Assembler::GetCondition(branch_instr) == ne);
1757 patcher.EmitCondition(eq); 1757 patcher.EmitCondition(eq);
1758 } 1758 }
1759 } 1759 }
1760 1760
1761 1761
1762 } } // namespace v8::internal 1762 } } // namespace v8::internal
1763 1763
1764 #endif // V8_TARGET_ARCH_ARM 1764 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | src/ia32/ic-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698