Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1663)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10375025: Whitespace change to force a build. (Closed)

Created:
8 years, 7 months ago by tfarina
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Whitespace change to force a build. NO CODE CHANGE. To see if it clears the unit_tests on "Mac 10.6 Tests. I doubt it'll though. TBR=rvargas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/whitespace_file.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
8 years, 7 months ago (2012-05-05 15:32:16 UTC) #1
tfarina
Like I thought this didn't help. May be it needs a clobber of the bot, ...
8 years, 7 months ago (2012-05-05 15:57:21 UTC) #2
tfarina
Would that revision http://src.chromium.org/viewvc/chrome?view=rev&revision=135521 somehow being causing the error? I don't how it could though. ...
8 years, 7 months ago (2012-05-05 16:06:28 UTC) #3
tfarina
On Sat, May 5, 2012 at 1:06 PM, Thiago Farina <tfarina@chromium.org> wrote: > Would that ...
8 years, 7 months ago (2012-05-05 16:07:11 UTC) #4
tfarina
8 years, 7 months ago (2012-05-05 17:44:55 UTC) #5 
On Sat, May 5, 2012 at 1:07 PM, Thiago Farina <tfarina@chromium.org> wrote:
> On Sat, May 5, 2012 at 1:06 PM, Thiago Farina <tfarina@chromium.org> wrote:
>> Would that revision
>> http://src.chromium.org/viewvc/chrome?view=rev&revision=135521 somehow
>> being causing the error? I don't how it could though.
>>
> s/I don't how/I don't know how
>
Alright, so Nico reverted it in
http://src.chromium.org/viewvc/chrome?view=rev&revision=135547 and it
cleared the unit_tests. Yay.

>> On Sat, May 5, 2012 at 12:57 PM, Thiago Farina <tfarina@chromium.org> wrote:
>>> Like I thought this didn't help. May be it needs a clobber of the bot,
>>> I doubt too.
>>>
>>> This is the test that has been failing. But I can't see any obvious
culprit.
>>>
>>> [ RUN      ] OneClickSigninBubbleControllerTest.ShowAndClickMultiple
>>>        0   unit_tests                          0x1a8d5e1a
_mh_execute_header
>>> + 56409626
>>>        1   unit_tests                          0x1a909cf1
_mh_execute_header
>>> + 56622321
>>>        2   libSystem.B.dylib                   0x94e551cb _sigtramp + 43
>>>        3   ???                                 0xffffffff 0x0 + 4294967295
>>>        4   CoreFoundation                      0x9502447a
>>> _CFXNotificationResetSessionForTask + 1514
>>>        5   CoreFoundation                      0x95024753
>>> _CFXNotificationPostNotification + 179
>>>        6   Foundation                          0x96c2b680
NSPopAutoreleasePool + 5088
>>>        7   Foundation                          0x96c34ed8
>>> _NSDescriptionWithLocaleFunc + 5464
>>>        8   AppKit                              0x93e1c877
>>> NSAccessibilityUnregisterUniqueIdForUIElement + 10947
>>>        9   AppKit                              0x93e1c270
>>> NSAccessibilityUnregisterUniqueIdForUIElement + 9404
>>>        10  unit_tests                          0x1a151095
_mh_execute_header
>>> + 48525461
>>>        11  AppKit                              0x93e09dde _NSGetCarbonMenu +
19071
>>>        12  AppKit                              0x93dfffba _NSKitBundle +
760
>>>        13  AppKit                              0x93dff91c NSApplicationMain
+ 2434
>>>        14  AppKit                              0x93dff55f NSApplicationMain
+ 1477
>>>        15  AppKit                              0x93e3f8a1 _NXActivateSelf +
9995
>>>        16  AppKit                              0x93e3f63a _NXActivateSelf +
9380
>>>        17  unit_tests                          0x1a0bbe44
_mh_execute_header
>>> + 47914564
>>>        18  unit_tests                          0x18df5e1e
_mh_execute_header
>>> + 28229150
>>>        19  unit_tests                          0x1a556030
_mh_execute_header
>>> + 52740144
>>>        20  unit_tests                          0x1a54f187
_mh_execute_header
>>> + 52711815
>>>        21  unit_tests                          0x1a54f754
_mh_execute_header
>>> + 52713300
>>>        22  unit_tests                          0x1a54fb58
_mh_execute_header
>>> + 52714328
>>>        23  unit_tests                          0x1a554be8
_mh_execute_header
>>> + 52734952
>>>        24  unit_tests                          0x1a556590
_mh_execute_header
>>> + 52741520
>>>        25  unit_tests                          0x1a5546bf
_mh_execute_header
>>> + 52733631
>>>        26  unit_tests                          0x1a356703
_mh_execute_header
>>> + 50644739
>>>        27  unit_tests                          0x19e75303
_mh_execute_header
>>> + 45527811
>>>        28  unit_tests                          0x1a5bb383
_mh_execute_header
>>> + 53154691
>>>        29  unit_tests                          0x173b9ab6 _mh_execute_header
+ 719542
>>> ax: d9cf220, bx: 96c2e3cb, cx: 1bd4a079, dx: d
>>> di: 8, si: ec23f50, bp: bfffed58, sp: bfffeca8, ss: 1f, flags: 210202
>>> ip: 95d14688, cs: 17, ds: 1f, es: 1f, fs: 0, gs: 37
>>> Unable to generate JSON from XML, using log output.[Running for
>>> master: "Chromium"]
>>> Generating json: builder_name:Mac10.5 Tests (2),
>>> build_name:Mac10_5_Tests__2_, build_number:16103,
>>> results_directory:gtest-results/unit_tests,
>>>
builder_base_url:http://build.chromium.org/buildbot/gtest_results/Mac10_5_Tests__2_/unit_tests,
>>>
webkit_dir:/Volumes/data/b/build/slave/Mac10_5_Tests__2_/build/src/third_party/WebKit/Source,
>>> chrome_dir:/Volumes/data/b/build/slave/Mac10_5_Tests__2_/build/src/build
>>> test_results_server:test-results.appspot.com, test_type:unit_tests,
>>> master_name:Chromium
>>> 120505 08:44:03 json_results_generator.py:301 INFO Uploading JSON
>>> files for builder: Mac10.5 Tests (2)
>>> 120505 08:44:04 json_results_generator.py:313 INFO JSON files uploaded.
>>>
>>> On Sat, May 5, 2012 at 12:32 PM,  <tfarina@chromium.org> wrote:
>>>> Reviewers: rvargas,
>>>>
>>>> Description:
>>>> Whitespace change to force a build.
>>>>
>>>> NO CODE CHANGE.
>>>>
>>>> To see if it clears the unit_tests on "Mac 10.6 Tests. I doubt it'll
though.
>>>>
>>>> TBR=rvargas@chromium.org
>>>>
>>>>
>>>> Please review this at http://codereview.chromium.org/10375025/
>>>>
>>>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>>>
>>>> Affected files:
>>>>  M build/whitespace_file.txt
>>>>
>>>>
>>>> Index: build/whitespace_file.txt
>>>> diff --git a/build/whitespace_file.txt b/build/whitespace_file.txt
>>>> index
>>>>
952394f22a952739e2fe559fa9906c84d7ace441..2aeed098b4474404e4af92d248e12caaaf2a3daf
>>>> 100644
>>>> --- a/build/whitespace_file.txt
>>>> +++ b/build/whitespace_file.txt
>>>> @@ -49,3 +49,5 @@ salmon in a cereal bowl.
>>>>  CHAPTER 4:
>>>>  The taste of stale sushi in his mouth the next morning was unbearable. He
>>>>  wondered where the sushi came from. He tries to recall the cook's face.
>>>> +
>>>> +CHAPTER 5:
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Thiago
>>
>>
>>
>> --
>> Thiago
>
>
>
> --
> Thiago



-- 
Thiago

Powered by Google App Engine
This is Rietveld 408576698