chrome/browser/extensions/extension_webstore_private_api.cc - Issue 10375021: Move Extension into extensions namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_webstore_private_api.cc

Issue 10375021: Move Extension into extensions namespace (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Take 2 Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_webstore_private_api.cc

diff --git a/chrome/browser/extensions/extension_webstore_private_api.cc b/chrome/browser/extensions/extension_webstore_private_api.cc

index b3efdd869348920731f4c6460f8b692d065ff747..6ec68768015298f65c796d98e01c0e7e6026305f 100644

--- a/chrome/browser/extensions/extension_webstore_private_api.cc

+++ b/chrome/browser/extensions/extension_webstore_private_api.cc

@@ -259,7 +259,7 @@ bool BeginInstallWithManifestFunction::RunImpl() {

CHECK(details);

EXTENSION_FUNCTION_VALIDATE(details->GetString(kIdKey, &id_));

- if (!Extension::IdIsValid(id_)) {

+ if (!extensions::Extension::IdIsValid(id_)) {

SetResult(INVALID_ID);

error_ = kInvalidIdError;

return false;

@@ -450,7 +450,7 @@ void BeginInstallWithManifestFunction::InstallUIAbort(bool user_initiated) {

bool CompleteInstallFunction::RunImpl() {

std::string id;

EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &id));

- if (!Extension::IdIsValid(id)) {

+ if (!extensions::Extension::IdIsValid(id)) {

error_ = kInvalidIdError;

return false;

}