Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 10375015: MSVS 2008: Fix to ensure that actions are re-run when the command changes (v2) (Closed)

Created:
8 years, 7 months ago by Mark Seaborn
Modified:
8 years, 7 months ago
Reviewers:
jeanluc1
CC:
gyp-developer_googlegroups.com, Ryan Sleevi
Base URL:
http://git.chromium.org/external/gyp.git@master
Visibility:
Public.

Description

MSVS 2008: Fix to ensure that actions are re-run when the command changes There was some code to re-run an action, but it only worked if the command change came from a change to a .gyp file, and only if the "inputs" list was empty. It didn't work if the command change came from a change to a .gypi file. To fix this, we create "*.gypcmd" stamp files that contain the command text, and when the command text changes we update these files' timestamps. If a Gyp target contains multiple actions, this should rerun only the actions that changed. BUG=http://code.google.com/p/gyp/issues/detail?id=262 TEST=test/actions-args-change Committed: https://code.google.com/p/gyp/source/detail?r=1362

Patch Set 1 #

Patch Set 2 : Style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -6 lines) Patch
M pylib/gyp/generator/msvs.py View 1 4 chunks +23 lines, -6 lines 0 comments Download
A test/actions-args-change/gyptest-all.py View 1 chunk +48 lines, -0 lines 0 comments Download
A test/actions-args-change/src/arg-action.gyp View 1 chunk +35 lines, -0 lines 0 comments Download
A test/actions-args-change/src/arg-action.gypi View 1 chunk +9 lines, -0 lines 0 comments Download
A test/actions-args-change/src/dummy-fixed-input.txt View 1 chunk +1 line, -0 lines 0 comments Download
A test/actions-args-change/src/write_file.py View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
This replaces http://codereview.chromium.org/10306013/ and fixes the problem Ryan raised about unnecessary rebuilds. It turned out ...
8 years, 7 months ago (2012-05-04 21:01:51 UTC) #1
jeanluc1
lgtm
8 years, 7 months ago (2012-05-04 22:30:14 UTC) #2
Ryan Sleevi
Thanks Mark! I reviewed-for-approach and I think this will be great. I don't know if ...
8 years, 7 months ago (2012-05-04 22:45:17 UTC) #3
M-A Ruel
8 years, 7 months ago (2012-05-16 10:53:33 UTC) #4
On 2012/05/04 22:45:17, Ryan Sleevi wrote:
> Thanks Mark! I reviewed-for-approach and I think this will be great. I don't
> know if it will wholly fix the MSVC 2008 issues for compiling .cc files,
meaning
> it won't help all of the WebKit woes, but looks fine for actions.

This seems to have killed the windows try slaves, as a random example;
http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/29535/...
These gypmd are removed at each try job. This seems to have turned every windows
try jobs into clobber compile.

Powered by Google App Engine
This is Rietveld 408576698