pylib/gyp/msvs_emulation.py - Issue 10371002: ninja windows: make sure there's a trailing slash on $(VCInstallDir)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/msvs_emulation.py

Issue 10371002: ninja windows: make sure there's a trailing slash on $(VCInstallDir) (Closed) Base URL: https://gyp.googlecode.com/svn/trunk

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/msvs_emulation.py

diff --git a/pylib/gyp/msvs_emulation.py b/pylib/gyp/msvs_emulation.py

index 9b65e21dd837e6a7b820af428e391ac3e8097310..2d7f7af91f046ac7f01f254003885939c08f2ce7 100644

--- a/pylib/gyp/msvs_emulation.py

+++ b/pylib/gyp/msvs_emulation.py

@@ -154,7 +154,7 @@ class MsvsSettings(object):

equivalents."""

replacements = {

'$(VSInstallDir)': self.vs_version.Path(),

- '$(VCInstallDir)': os.path.join(self.vs_version.Path(), 'VC'),

+ '$(VCInstallDir)': os.path.join(self.vs_version.Path(), 'VC') + "\\",

Nico 2012/05/03 22:28:09 nit: ' not ", for local consistency

scottmg 2012/05/03 22:41:36 Done. 5 non-space characters, and I get 40% of th

'$(OutDir)\\': base_to_build + '\\' if base_to_build else '',

'$(IntDir)': '$!INTERMEDIATE_DIR',

'$(InputPath)': '${source}',

« no previous file with comments | « no previous file | test/win/gyptest-macro-vcinstalldir.py » ('j') | no next file with comments »