Issue 10368006: Remove the hack to concat .d files into a single deps file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10368006: Remove the hack to concat .d files into a single deps file. (Closed)

Created:
8 years, 7 months ago by tony

Modified:
8 years, 7 months ago

Reviewers:
Nico, Evan Martin

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove the hack to concat .d files into a single deps file. The speed improvements were minor (maybe 200ms) and it was reported that on a RAM disk, it was slower. It also was causing some users to overflow the command line by having 1000 filenames in a single line. Since it adds a lot of complexity to the Makefile, let's just remove it. Committed: https://code.google.com/p/gyp/source/detail?r=1361

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -45 lines)			Patch
	M	pylib/gyp/generator/make.py	View	1	10 chunks	+7 lines, -40 lines	0 comments	Download
	M	test/make/gyptest-dependencies.py	View	1	2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages