Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: build/common.gypi

Issue 10366002: enable incremental linking by default when using ninja on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: now actually tested Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c836456776266251f8dc54cdbd28b6bc5377d4fd..5d67d11df66dc1b3dfdde4da5f9933df49ec04ec 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -703,7 +703,7 @@
# Needed for some of the largest modules.
'msvs_debug_link_nonincremental%': '1',
- # Turn on Use Library Dependency Inputs for linking chrome.dll on Windows
+ # Turns on Use Library Dependency Inputs for linking chrome.dll on Windows
# to get incremental linking to be faster in debug builds.
'incremental_chrome_dll%': '0',
@@ -1042,6 +1042,10 @@
['component=="shared_library"', {
'win_use_allocator_shim%': 0,
}],
+ ['"<(GENERATOR)"=="ninja"', {
+ # Only enabled by default for ninja because it's buggy in VS.
+ 'incremental_chrome_dll%': 1,
+ }],
# Whether to use multiple cores to compile with visual studio. This is
# optional because it sometimes causes corruption on VS 2005.
# It is on by default on VS 2008 and off on VS 2005.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698