Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Issue 10365030: Configure gdb for nacl target (Closed)

Created:
8 years, 7 months ago by halyavin
Modified:
8 years, 7 months ago
Reviewers:
eaeltsin
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gdb.git@nacl-stub
Visibility:
Public.

Description

Configure gdb for nacl target BUG= none TEST= none Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=4b7b669

Patch Set 1 #

Patch Set 2 : convert spaces to tabs #

Patch Set 3 : 80 symbols #

Total comments: 4

Patch Set 4 : I made nacl target more specific #

Patch Set 5 : Remove changes from i686-nacl target in bfd. #

Total comments: 2

Patch Set 6 : Remove i686 case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M bfd/config.bfd View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M gdb/configure.tgt View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
halyavin
8 years, 7 months ago (2012-05-05 15:21:47 UTC) #1
eaeltsin
Can you please add more details in the changeset description? Probably we only need x86_64-nacl-gdb, ...
8 years, 7 months ago (2012-05-05 16:16:50 UTC) #2
eaeltsin
https://chromiumcodereview.appspot.com/10365030/diff/5001/bfd/config.bfd File bfd/config.bfd (right): https://chromiumcodereview.appspot.com/10365030/diff/5001/bfd/config.bfd#newcode576 bfd/config.bfd:576: targ64_selvecs="bfd_elf64_x86_64_vec bfd_elf32_x86_64_vec bfd_elf64_l1om_vec bfd_elf64_k1om_vec" We probably don't need this ...
8 years, 7 months ago (2012-05-05 16:20:42 UTC) #3
halyavin
https://chromiumcodereview.appspot.com/10365030/diff/5001/gdb/configure.tgt File gdb/configure.tgt (right): https://chromiumcodereview.appspot.com/10365030/diff/5001/gdb/configure.tgt#newcode227 gdb/configure.tgt:227: *nacl*) On 2012/05/05 16:20:47, eaeltsin wrote: > We need ...
8 years, 7 months ago (2012-05-10 08:21:41 UTC) #4
halyavin
https://chromiumcodereview.appspot.com/10365030/diff/5001/bfd/config.bfd File bfd/config.bfd (right): https://chromiumcodereview.appspot.com/10365030/diff/5001/bfd/config.bfd#newcode576 bfd/config.bfd:576: targ64_selvecs="bfd_elf64_x86_64_vec bfd_elf32_x86_64_vec bfd_elf64_l1om_vec bfd_elf64_k1om_vec" On 2012/05/05 16:20:47, eaeltsin wrote: ...
8 years, 7 months ago (2012-05-10 09:23:31 UTC) #5
eaeltsin
lgtm with one change below. https://chromiumcodereview.appspot.com/10365030/diff/10001/gdb/configure.tgt File gdb/configure.tgt (right): https://chromiumcodereview.appspot.com/10365030/diff/10001/gdb/configure.tgt#newcode227 gdb/configure.tgt:227: i[34567]86-*-nacl* | x86_64-*-nacl*) As ...
8 years, 7 months ago (2012-05-10 09:28:30 UTC) #6
halyavin
8 years, 7 months ago (2012-05-10 10:09:00 UTC) #7
https://chromiumcodereview.appspot.com/10365030/diff/10001/gdb/configure.tgt
File gdb/configure.tgt (right):

https://chromiumcodereview.appspot.com/10365030/diff/10001/gdb/configure.tgt#...
gdb/configure.tgt:227: i[34567]86-*-nacl* | x86_64-*-nacl*)
On 2012/05/10 09:28:30, eaeltsin wrote:
> As we discussed in person, you don't need i[34567]86-*-nacl* at all, we should
> not configure for this target.
> 
> Please keep only x86_64-*-nacl* here.

Done.

Powered by Google App Engine
This is Rietveld 408576698