Debug stub: associate NaClAppThread with IThread

src/trusted/gdb_rsp/test.cc

Index: src/trusted/gdb_rsp/test.cc
diff --git a/src/trusted/gdb_rsp/test.cc b/src/trusted/gdb_rsp/test.cc
index bb9e61c5c922a690ad2300b42ba9ec0a88a665e3..4e1a880d32b0eab0eba19d9830dfed5999062b93 100644
--- a/src/trusted/gdb_rsp/test.cc
+++ b/src/trusted/gdb_rsp/test.cc
@@ -99,9 +99,8 @@ class ThreadMock : public IThread {
   uint32_t id_;
 };
 
-IThread* IThread::Acquire(uint32_t id, bool create) {
-  if (create) return new ThreadMock(id);
-  return NULL;
+IThread* IThread::Create(uint32_t id, struct NaClAppThread *) {

[Mark Seaborn, 2012/05/07 21:56:49]

Please use "struct NaClAppThread *natp"; make sure arguments have names.

[eaeltsin, 2012/05/08 11:10:19]

Not naming unused parameters is a very common C++ practice. It combines a note
from C++ standard (for 2005 see 8.4  Function definitions) that "unused
parameters need not be named" and de-facto standard for compiler behavior to
suppress the "unused parameter" warning in this case (which becomes an error
with our settings). 

I'm not keen on including a file just for using a macro just for suppressing a
warning, but if you insist I can use UNREFERENCED_PARAMETER here.

[Mark Seaborn, 2012/05/09 00:06:06]

If a parameter is nameless, how do you view its contents in a debugger?

Names are also good for documenting the code.

I'll let this one go because it's in this test file and this particular test
probably isn't very useful.

+  return new ThreadMock(id);
 }