Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 10365027: Allow renderers to shut down if they only contain swapped out views. (Closed)

Created:
8 years, 7 months ago by Charlie Reis
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Allow renderers to shut down if they only contain swapped out views. BUG=126333 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136168

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -3 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +26 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 2 chunks +80 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Charlie Reis
John, since you looked at my earlier CL for this (http://codereview.chromium.org/9751001/), can you review this ...
8 years, 7 months ago (2012-05-07 17:34:36 UTC) #1
Charlie Reis
Oops, John's OOO. Matt, can you take a look?
8 years, 7 months ago (2012-05-08 01:07:54 UTC) #2
Matt Perry
lgtm
8 years, 7 months ago (2012-05-09 19:16:29 UTC) #3
Charlie Reis
Avi, can you take a look for content/browser OWNERs approval?
8 years, 7 months ago (2012-05-09 19:24:01 UTC) #4
Avi (use Gerrit)
lgtm
8 years, 7 months ago (2012-05-09 21:35:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/10365027/5001
8 years, 7 months ago (2012-05-09 21:36:05 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-09 23:40:18 UTC) #7
Change committed as 136168

Powered by Google App Engine
This is Rietveld 408576698