Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3046)

Unified Diff: chrome/test/data/extensions/api_test/downloads/test.js

Issue 10365012: Update net::HttpUtil::IsSafeHeader() with two new headers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/downloads/test.js
diff --git a/chrome/test/data/extensions/api_test/downloads/test.js b/chrome/test/data/extensions/api_test/downloads/test.js
index 4d951911a5535baaf7e50301312d66a29203c1c2..7e9e8f9dbb7cd14f529f8d3fb1e9bdc4d88b4d51 100644
--- a/chrome/test/data/extensions/api_test/downloads/test.js
+++ b/chrome/test/data/extensions/api_test/downloads/test.js
@@ -694,25 +694,23 @@ chrome.test.getConfig(function(testConfig) {
chrome.test.callbackFail(downloads.ERROR_GENERIC));
},
- // TODO(benjhayden): Find why these aren't caught by
- // net::HttpUtil::IsSafeHeader().
- // function downloadHeadersInvalid23() {
- // // Test that we disallow certain headers.
- // downloads.download(
- // {'url': SAFE_FAST_URL,
- // 'headers': [{'name': 'Access-Control-Request-Headers',
- // 'value': 'evil'}]},
- // chrome.test.callbackFail(downloads.ERROR_GENERIC));
- // },
+ function downloadHeadersInvalid23() {
+ // Test that we disallow certain headers.
+ downloads.download(
+ {'url': SAFE_FAST_URL,
+ 'headers': [{'name': 'Access-Control-Request-Headers',
+ 'value': 'evil'}]},
+ chrome.test.callbackFail(downloads.ERROR_GENERIC));
+ },
- // function downloadHeadersInvalid24() {
- // // Test that we disallow certain headers.
- // downloads.download(
- // {'url': SAFE_FAST_URL,
- // 'headers': [{'name': 'Access-Control-Request-Method',
- // 'value': 'evil'}]},
- // chrome.test.callbackFail(downloads.ERROR_GENERIC));
- // },
+ function downloadHeadersInvalid24() {
+ // Test that we disallow certain headers.
+ downloads.download(
+ {'url': SAFE_FAST_URL,
+ 'headers': [{'name': 'Access-Control-Request-Method',
+ 'value': 'evil'}]},
+ chrome.test.callbackFail(downloads.ERROR_GENERIC));
+ },
function downloadInterrupted() {
// Test that cancel()ing an in-progress download causes its state to
« no previous file with comments | « no previous file | net/http/http_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698