Issue 10358013: views: Mark single-argument constructors as explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10358013: views: Mark single-argument constructors as explicit. (Closed)

Created:
8 years, 7 months ago by tfarina

Modified:
8 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

views: Mark single-argument constructors as explicit. This was reported by cpplint as: python ~/depot_tools/cpplint.py $(find ui/views/ -type f -name \*.cc) 2>&1 | grep -v "Done processing" | grep explicit R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135365

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -33 lines)			Patch
M	ui/views/border.cc	View	3 chunks	+11 lines, -7 lines	0 comments	Download
M	ui/views/bubble/bubble_frame_view_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/controls/button/text_button.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	ui/views/controls/combobox/native_combobox_views_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/menu/menu_model_adapter_unittest.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	ui/views/controls/menu/native_menu_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/scrollbar/scroll_bar.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	ui/views/controls/throbber.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/examples/bubble_example.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/paint_lock.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/touchui/touch_selection_controller_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/widget/native_widget_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/widget/widget_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM