Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 10358010: Fix register clobbering in LoadIC for interceptors. (Closed)

Created:
8 years, 7 months ago by Michael Starzinger
Modified:
8 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix register clobbering in LoadIC for interceptors. This fixes a corner-case where the receiver register was clobbered by LoadICs for interceptors and inlined followup code still relied on the receiver to be intact in case of prototype changes. R=vegorov@chromium.org BUG=chromium:125988 TEST=cctest/test-api/Regress125988 Committed: https://code.google.com/p/v8/source/detail?r=11492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -12 lines) Patch
M src/arm/stub-cache-arm.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 3 chunks +18 lines, -4 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 7 months ago (2012-05-03 10:49:04 UTC) #1
Vyacheslav Egorov (Chromium)
8 years, 7 months ago (2012-05-03 11:05:45 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698