Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 10358008: Fix assert triggered in fast/regex/pcre-test-4.html We were not filtering out (Closed)

Created:
8 years, 7 months ago by Erik Corry
Modified:
8 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Fix assert triggered in fast/regex/pcre-test-4.html We were not filtering out all the nodes that had non-ASCII characters. That has been fixed, but because of the protection against over-deep recursion when filtering it is wrong to assert that all nodes were filtered. This change therefore also makes sure we can cope with non-filtered nodes by adding back some code removed in https://chromiumcodereview.appspot.com/10174017/ Committed: https://code.google.com/p/v8/source/detail?r=11487

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -16 lines) Patch
M src/jsregexp.cc View 4 chunks +28 lines, -16 lines 1 comment Download
M test/mjsunit/regexp-capture-3.js View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
8 years, 7 months ago (2012-05-03 07:50:38 UTC) #1
ulan
8 years, 7 months ago (2012-05-03 08:18:45 UTC) #2
LGTM with comments.

https://chromiumcodereview.appspot.com/10358008/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):

https://chromiumcodereview.appspot.com/10358008/diff/1/src/jsregexp.cc#newcod...
src/jsregexp.cc:2432: // matching can turn an ASCII character into non-ASCII or
Tabs and trailing spaces in this block.

Powered by Google App Engine
This is Rietveld 408576698