Issue 10356150: Grokdump -f: Automatically detect memory that is x86/x64 instructions or text and dump appropriatel…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10356150: Grokdump -f: Automatically detect memory that is x86/x64 instructions or text and dump appropriatel… (Closed)

Created:
8 years, 7 months ago by Erik Corry

Modified:
8 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Grokdump -f: Automatically detect memory that is x86/x64 instructions or text and dump appropriately. Committed: https://code.google.com/p/v8/source/detail?r=11621

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -47 lines)			Patch
	M	tools/grokdump.py	View	1	3 chunks	+156 lines, -47 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

I updated this change to handle ASCII 0x7f (DEL) correctly and to produce some info ...

8 years, 7 months ago (2012-05-16 12:22:55 UTC) #2

Michael Starzinger

8 years, 7 months ago (2012-05-21 12:03:13 UTC) #3

LGTM (with one nit).

https://chromiumcodereview.appspot.com/10356150/diff/3001/tools/grokdump.py
File tools/grokdump.py (right):

https://chromiumcodereview.appspot.com/10356150/diff/3001/tools/grokdump.py#n...
tools/grokdump.py:511: def IsASCIIRegion(self, location, length):
Maybe we should rename this to IsProbableASCIIRegion, because the determination
isn't accurate, it's basically just guessing.

https://chromiumcodereview.appspot.com/10356150/diff/3001/tools/grokdump.py#n...
tools/grokdump.py:532: def IsExecutableRegion(self, location, length):
Likewise.

Expand Messages | Collapse Messages