Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 10356143: Serialize heap snapshot data as an array of unsigned values. (Closed)

Created:
8 years, 7 months ago by alexeif
Modified:
8 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Serialize heap snapshot data as an array of unsigned values. None of the values can in fact be negative, while object IDs can have the highest bit set which lead to negative values appear in the snapshot that front-end is unable to parse. Committed: https://code.google.com/p/v8/source/detail?r=11553

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M src/profile-generator.cc View 3 chunks +13 lines, -20 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
alexeif
8 years, 7 months ago (2012-05-12 15:38:04 UTC) #1
yurys
8 years, 7 months ago (2012-05-12 16:26:33 UTC) #2
lgtm

http://codereview.chromium.org/10356143/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/10356143/diff/1/src/profile-generator.cc#newco...
src/profile-generator.cc:3502: static int utoa(unsigned value, const
Vector<char>& buffer, int buffer_pos) {
Not directly related to this change but we need to do something about
v8::RetainedObjectInfo::GetHash return value to make sure the ids are unique
after hashing.

Powered by Google App Engine
This is Rietveld 408576698