Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10356138: Allow overriding GYP_GENERATORS in chromium.gyp_env. (Closed)

Created:
8 years, 7 months ago by Jói
Modified:
8 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews
Visibility:
Public.

Description

Allow overriding GYP_GENERATORS in chromium.gyp_env. This is useful e.g. if you use Ninja. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136921

Patch Set 1 #

Patch Set 2 : lkgr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/gyp_chromium View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Jói
8 years, 7 months ago (2012-05-11 22:55:25 UTC) #1
TVL
lgtm
8 years, 7 months ago (2012-05-12 00:23:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/10356138/1
8 years, 7 months ago (2012-05-14 16:48:04 UTC) #3
commit-bot: I haz the power
Try job failure for 10356138-1 (retry) on win for step "runhooks" (clobber build). It's a ...
8 years, 7 months ago (2012-05-14 17:02:58 UTC) #4
Jói
lkgr
8 years, 7 months ago (2012-05-14 17:04:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/10356138/11001
8 years, 7 months ago (2012-05-14 17:04:25 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-14 18:39:33 UTC) #7
Change committed as 136921

Powered by Google App Engine
This is Rietveld 408576698