Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 10356116: Add "libraries" directory to SDK (Closed)

Created:
8 years, 7 months ago by noelallen1
Modified:
8 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add "libraries" directory to SDK Adds the PPAPI headers where they can be used by a host compiler. Adds a define for PPAPI_RELEASE when building for the SDK. Disables updater testing when not generating tarballs. BUG=122229 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136614

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 4 chunks +5 lines, -1 line 0 comments Download
M ppapi/generators/idl_c_header.py View 2 chunks +10 lines, -0 lines 4 comments Download

Messages

Total messages: 6 (0 generated)
noelallen1
8 years, 7 months ago (2012-05-10 20:52:35 UTC) #1
binji
lgtm
8 years, 7 months ago (2012-05-10 21:04:17 UTC) #2
dmichael (off chromium)
https://chromiumcodereview.appspot.com/10356116/diff/1/ppapi/generators/idl_c_header.py File ppapi/generators/idl_c_header.py (right): https://chromiumcodereview.appspot.com/10356116/diff/1/ppapi/generators/idl_c_header.py#newcode176 ppapi/generators/idl_c_header.py:176: # If we are generating a single release, then ...
8 years, 7 months ago (2012-05-10 22:33:58 UTC) #3
noelallen1
https://chromiumcodereview.appspot.com/10356116/diff/1/ppapi/generators/idl_c_header.py File ppapi/generators/idl_c_header.py (right): https://chromiumcodereview.appspot.com/10356116/diff/1/ppapi/generators/idl_c_header.py#newcode176 ppapi/generators/idl_c_header.py:176: # If we are generating a single release, then ...
8 years, 7 months ago (2012-05-11 18:07:27 UTC) #4
dmichael (off chromium)
lgtm
8 years, 7 months ago (2012-05-11 18:20:36 UTC) #5
dmichael (off chromium)
8 years, 7 months ago (2012-05-11 18:22:08 UTC) #6
I mentioned this in IM, but I'll mention it here for posterity...

I think you're going to need to generate all versions of the interfaces in the C
headers, since the C++ layer relies on those now.

Also, I'm fine with this version information appearing in the headers in Chrome
(not just the SDK). I think it's a good idea.

still lgtm

Powered by Google App Engine
This is Rietveld 408576698