Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: tests/language/bit_shift_test.dart

Issue 10356095: The shift-amount must not be anded with 31. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/lib/js_helper.dart ('k') | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/bit_shift_test.dart
diff --git a/tests/language/bit_shift_test.dart b/tests/language/bit_shift_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..edbd1eb5c5d19f5ad2c44b65565c27195fe0638d
--- /dev/null
+++ b/tests/language/bit_shift_test.dart
@@ -0,0 +1,46 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+constants() {
+ Expect.equals(0, 499 >> 33);
+ Expect.equals(0, (499 << 33) & 0xFFFFFFFF);
+}
+
+foo(i) {
+ if (i != 0) {
+ y--;
+ foo(i - 1);
+ y++;
+ }
+}
+
+var y;
+
+// id returns [x] in a way that should be difficult to predict statically.
+id(x) {
+ y = x;
+ foo(10);
+ return y;
+}
+
+interceptors() {
+ Expect.equals(0, id(499) >> 33);
+ Expect.equals(0, (id(499) << 33) & 0xFFFFFFFF);
+}
+
+speculative() {
+ var a = id(499);
+ for (int i = 0; i < 1; i++) {
+ Expect.equals(0, a >> 33);
+ Expect.equals(0, (a << 33) & 0xFFFFFFFF);
+ }
+}
+
+// JavaScript shifts by the amount modulo 32. That is x << y is equivalent to
+// x << (y & 0x1F). Dart does not.
+main() {
+ constants();
+ interceptors();
+ speculative();
+}
« no previous file with comments | « lib/compiler/implementation/lib/js_helper.dart ('k') | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698