Issue 10356071: Force checking of result on all functions in elements.h that return MaybeObject*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10356071: Force checking of result on all functions in elements.h that return MaybeObject*. (Closed)

Created:
8 years, 7 months ago by fschneider

Modified:
8 years, 7 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Force checking of result on all functions in elements.h that return MaybeObject*. Add two missing failure checks found by this. Committed: https://code.google.com/p/v8/source/detail?r=11530

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -30 lines)			Patch
	M	src/elements.h	View	1	3 chunks	+30 lines, -27 lines	0 comments	Download
	M	src/objects.cc	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

LGTM with nits. https://chromiumcodereview.appspot.com/10356071/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10356071/diff/1/src/objects.cc#newcode8627 src/objects.cc:8627: } nit: wacky formatting. why not ...

8 years, 7 months ago (2012-05-09 12:14:44 UTC) #2

fschneider

8 years, 7 months ago (2012-05-09 12:49:50 UTC) #3

https://chromiumcodereview.appspot.com/10356071/diff/1/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10356071/diff/1/src/objects.cc#newcode...
src/objects.cc:8674: }
On 2012/05/09 12:14:44, danno wrote:
> nit: wacky formatting. why not just omit the {} and use normal indentation
here?
> 

Fixed indentation.

I still like to keep the {} to easily spot that the check for failure is present
and for consistency with the existing code.

Expand Messages | Collapse Messages

Issue 10356071: Force checking of result on all functions in elements.h that return MaybeObject*. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages