Issue 10356060: Fix precompiled header test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10356060: Fix precompiled header test (Closed)

Created:
8 years, 7 months ago by scottmg

Modified:
8 years, 7 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
https://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Because the files are .c and were without warnings-as-errors, the non-declared call to printf that was intended to cause an error ended up just being a warning. So, if PCH wasn't working, the test would succeed anyway. Turn on warnings-as-errors to fix this. Committed: https://code.google.com/p/gyp/source/detail?r=1366

Patch Set 1 #

Patch Set 2 : remove ninja changes #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	test/msvs/precompiled/hello.gyp	View		2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages