lib/compiler/implementation/operations.dart - Issue 10356053: Prettify !(x rel-op y) into (x "!rel-op" y) when possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/operations.dart

Issue 10356053: Prettify !(x rel-op y) into (x "!rel-op" y) when possible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « lib/compiler/implementation/compile_time_constants.dart ('k') | lib/compiler/implementation/ssa/codegen.dart » ('j') | lib/compiler/implementation/ssa/codegen.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/operations.dart

diff --git a/lib/compiler/implementation/operations.dart b/lib/compiler/implementation/operations.dart

index 4b85e881042379e109c50fe8fe10e432c999927f..3e2d8fb22e45c148b06e1a8e756d0c6b76b6920b 100644

--- a/lib/compiler/implementation/operations.dart

+++ b/lib/compiler/implementation/operations.dart

@@ -168,6 +168,7 @@ class ArithmeticNumOperation implements BinaryOperation {

return new DoubleConstant(foldedValue);

}

+ return null;

}

bool isDivide() => false;