Disable off-store extension installs by default.

chrome/browser/ui/intents/web_intent_picker_controller.cc

Index: chrome/browser/ui/intents/web_intent_picker_controller.cc
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.cc b/chrome/browser/ui/intents/web_intent_picker_controller.cc
index daa7ace9984d7910fff810006c3bbec9f734413d..f4d0fbf6260c7cd1a5a3bf39871ee48a36a8d519 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller.cc
+++ b/chrome/browser/ui/intents/web_intent_picker_controller.cc
@@ -307,10 +307,15 @@ void WebIntentPickerController::OnInlineDispositionWebContentsCreated(
 
 void WebIntentPickerController::OnExtensionInstallRequested(
     const std::string& id) {
+  // Only need to set extension_id, manifest, etc, if we want to skip the

[Mihai Parparita -not on Chrome, 2012/05/14 23:25:04]

Nit: You could enforce this by making Approval into a class with a private
constructor, and adding factory methods like
Approval::CreateWithNoInstallPrompt(profile, extension_id, manifest, ...) and
Approval::CreateWithInstallPrompt(profile), instead of relying on callers
populating fields like skip_install_dialog and ones they depend on.

[Aaron Boodman, 2012/05/15 05:30:07]

Done, trybotting.

+  // install dialog.
+  scoped_ptr<WebstoreInstaller::Approval> approval(
+      new WebstoreInstaller::Approval());
+  approval->profile = wrapper_->profile();
+
   scoped_refptr<WebstoreInstaller> installer = new WebstoreInstaller(
       wrapper_->profile(), this, &wrapper_->web_contents()->GetController(), id,
-      scoped_ptr<WebstoreInstaller::Approval>(NULL),
-      WebstoreInstaller::FLAG_INLINE_INSTALL);
+      approval.Pass(), WebstoreInstaller::FLAG_INLINE_INSTALL);
 
   pending_async_count_++;
   installer->Start();