Disable off-store extension installs by default.

Disable off-store extension installs by default. Also get rid of ExtensionService::IsDownloadFromGallery.

BUG=55584
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137540

[Matt Perry, 2012-05-08 17:41:23]

lgtm

[Aaron Boodman, 2012-05-11 19:11:44]

+mihaip - Mihai, can you take a look at the WebstoreInstaller changes? I'm not
sure why that was limited to the inline install case. Is there a problem with
broadening it?

[Mihai Parparita -not on Chrome, 2012-05-12 00:15:44]

https://chromiumcodereview.appspot.com/10356052/diff/12001/chrome/browser/ext...
File chrome/browser/extensions/webstore_installer.cc (right):

https://chromiumcodereview.appspot.com/10356052/diff/12001/chrome/browser/ext...
chrome/browser/extensions/webstore_installer.cc:293: GURL referrer =
GURL(extension_urls::GetWebstoreItemDetailURLPrefix() + id_);
For the sake of posterity, Aaron and I discussed this a bit in #crx, and my take
is that the referrer spoofing is a hack, so we don't want to spread it even
further (e.g. for non-inline installs).

Generally, the ideal fix is to remove it entirely, and use Jon's spiffy new
"Approval" struct to keep track of webstore vs. non-webstore installs, instead
of doing referrer checks in places like
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/download/ch....

[Aaron Boodman, 2012-05-13 16:40:58]

Mihai, PTAL.

Removed ExtensionService::IsDownloadFromGallery.

[Mihai Parparita -not on Chrome, 2012-05-14 23:25:03]

LGTM, thanks for the cleanup. Update the CL description to mention it perhaps?

https://chromiumcodereview.appspot.com/10356052/diff/18001/chrome/browser/ui/...
File chrome/browser/ui/intents/web_intent_picker_controller.cc (right):

https://chromiumcodereview.appspot.com/10356052/diff/18001/chrome/browser/ui/...
chrome/browser/ui/intents/web_intent_picker_controller.cc:310: // Only need to
set extension_id, manifest, etc, if we want to skip the
Nit: You could enforce this by making Approval into a class with a private
constructor, and adding factory methods like
Approval::CreateWithNoInstallPrompt(profile, extension_id, manifest, ...) and
Approval::CreateWithInstallPrompt(profile), instead of relying on callers
populating fields like skip_install_dialog and ones they depend on.

[Aaron Boodman, 2012-05-15 05:30:07]

https://chromiumcodereview.appspot.com/10356052/diff/18001/chrome/browser/ui/...
File chrome/browser/ui/intents/web_intent_picker_controller.cc (right):

https://chromiumcodereview.appspot.com/10356052/diff/18001/chrome/browser/ui/...
chrome/browser/ui/intents/web_intent_picker_controller.cc:310: // Only need to
set extension_id, manifest, etc, if we want to skip the
On 2012/05/14 23:25:04, Mihai Parparita wrote:
> Nit: You could enforce this by making Approval into a class with a private
> constructor, and adding factory methods like
> Approval::CreateWithNoInstallPrompt(profile, extension_id, manifest, ...) and
> Approval::CreateWithInstallPrompt(profile), instead of relying on callers
> populating fields like skip_install_dialog and ones they depend on.

Done, trybotting.

[Aaron Boodman, 2012-05-16 21:17:20]

+jhawkins for intents

[James Hawkins, 2012-05-16 21:43:27]

lgtm

[commit-bot: I haz the power, 2012-05-16 21:50:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/10356052/8004