Issue 10354017: Creates OWNERS files for app_list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10354017: Creates OWNERS files for app_list. (Closed)

Created:
8 years, 7 months ago by sky

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, xiyuan

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Creates OWNERS files for app_list. R=ben@chromium.org TBR=ben@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135184

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	A	ash/app_list/OWNERS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	chrome/browser/ui/views/ash/app_list/OWNERS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 7 months ago (2012-05-03 21:24:13 UTC) #2

LGTM

On Thu, May 3, 2012 at 11:25 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Creates OWNERS files for app_list.
>
>
> R=ben@chromium.org
> TBR=ben@chromium.org
> BUG=none
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/10354017/<http://codereview.chromium.org/103...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  A ash/app_list/OWNERS
>  A chrome/browser/ui/views/ash/**app_list/OWNERS
>
>
> Index: ash/app_list/OWNERS
> diff --git a/ash/app_list/OWNERS b/ash/app_list/OWNERS
> new file mode 100644
> index 000000000000000000000000000000**0000000000..**
> ff3209c327b5f247d208ba9c2e15ce**4e96b9336d
> --- /dev/null
> +++ b/ash/app_list/OWNERS
> @@ -0,0 +1 @@
> +xiyuan@chromium.org
> Index: chrome/browser/ui/views/ash/**app_list/OWNERS
> diff --git a/chrome/browser/ui/views/ash/**app_list/OWNERS
> b/chrome/browser/ui/views/ash/**app_list/OWNERS
> new file mode 100644
> index 000000000000000000000000000000**0000000000..**
> ff3209c327b5f247d208ba9c2e15ce**4e96b9336d
> --- /dev/null
> +++ b/chrome/browser/ui/views/ash/**app_list/OWNERS
> @@ -0,0 +1 @@
> +xiyuan@chromium.org
>
>
>

Expand Messages | Collapse Messages